ci: optimize pull request checks - #6938
Merged
kuny0707 merged 2 commits intoSep 18, 2026
Merged
Conversation
enable task-output caching for x86 build and coverage jobs align PR title validation and reviewer routing with contributing rules
bladehan1
force-pushed
the
feature/ci_refactor
branch
from
September 1, 2026 06:25
348bc82 to
26e5a12
Compare
halibobo1205
reviewed
Sep 1, 2026
halibobo1205
approved these changes
Sep 3, 2026
317787106
reviewed
Sep 17, 2026
|
|
||
| - name: Build | ||
| run: ./gradlew clean build --no-daemon --no-build-cache | ||
| run: ./gradlew clean build --no-daemon |
Collaborator
There was a problem hiding this comment.
It is recommended to state in the PR description that org.gradle.caching=true has already been specified in gradle.properties, so that users are aware of the environment configuration.
Collaborator
Author
There was a problem hiding this comment.
Verified and done. org.gradle.caching=true is present in the committed gradle.properties on the base branch (release_v4.8.3) — it predates this PR, and since the Gradle build cache is disabled by default, this committed property is exactly what enables it. The PR description now states this explicitly under "Extra details".
317787106
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--no-build-cacheflags from Debian and Coverage Base builds and RocksDB tests.type(scope): description, including a space immediately after the colon, and provide a dedicated error when that space is missing.ci: descriptiontitle to the existingcireviewer scope; explicit scopes still take precedence and other bare types retain default reviewers.Why are these changes required?
The repository already enables Gradle Build Cache. However, four x86 Gradle invocations disable task-output cache reads and writes globally. Removing those flags enables reuse for eligible compile, package, Checkstyle, and test tasks.
CONTRIBUTING.mdrequires thetype: descriptionortype(scope): descriptionformat and states that CI enforces it. Requiring the space after the colon keeps validation consistent with the documented rule, while the dedicated error makes the correction explicit.Since
ciis also an existing reviewer scope, a barecitype can be mapped without inventing mappings for unrelated types.This PR has been tested by:
.github/workflows/pr-build.yml,.github/workflows/pr-check.yml, and.github/workflows/pr-reviewer.ymlci, and other bare types--no-build-cachegit diff --check./gradlew -g /private/tmp/java-tron-gradle-home :framework:checkstyleMain :framework:checkstyleTest :plugins:checkstyleMain --no-daemon --no-build-cache:framework:testWithRocksDbcache validation: an identical-input clean run restored the taskFROM-CACHE; changing-DrunPrecompileBenchmark=truecaused the task to execute while unrelated eligible tasks remained cachedFollow up
--rerunif a future test contract requires real execution for every CI run.Extra details
org.gradle.caching=trueis specified in the committedgradle.propertiesat the repository root (present on the base branch, not introduced by this PR). The Gradle build cache is disabled by default, and Gradle reads this file automatically, so no command-line flag or environment change is required. This PR only removes the four invocation-level--no-build-cacheoverrides that were suppressing that baseline configuration.cleanremoves projectbuild/output but does not remove$GRADLE_USER_HOME/caches/build-cache-1; eligible outputs can therefore be restored afterclean.