Skip to content

API key client option - #486

Merged
cretz merged 2 commits into
temporalio:mainfrom
cretz:api-key
Mar 13, 2024
Merged

cretz merged 2 commits into
temporalio:mainfrom
cretz:api-key

Conversation

@cretz

@cretz cretz commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

What was changed

Implements temporalio/features#426

  • Add api_key option to Client constructor
  • Add api_key property (including setter) to Client

These will set the "Authorization" header with the key prepended with "Bearer ". This leverages temporalio/sdk-rust#699.

Checklist

  1. Closes [Feature Request] API key client option #482

@cretz
cretz requested a review from a team as a code owner March 8, 2024 16:23
@cretz
cretz requested review from a team and removed request for a team March 8, 2024 16:26
@cretz

cretz commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

Moving this to draft, because we are delegating some of this work to core: temporalio/sdk-rust#699.

@cretz
cretz marked this pull request as draft March 8, 2024 22:58
@cretz

cretz commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

Moving back to ready-for-review. This now uses a core-based set of helpers.

@cretz
cretz marked this pull request as ready for review March 11, 2024 20:57
@cretz
cretz merged commit f3d1b85 into temporalio:main Mar 13, 2024
@cretz
cretz deleted the api-key branch March 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] API key client option

2 participants