Conversation
Member
|
Thanks @paul-buerkner! Looks good. I'll see what's up with the failing checks |
Member
|
I think the problem is that the most recent ggplot2 release fixed a bug in geom_hex that affects a few of our visual tests. I just updated the SVG files for the tests and hopefully the checks will pass now. |
jgabry
approved these changes
Mar 16, 2023
jgabry
left a comment
Member
There was a problem hiding this comment.
Will merge if the checks pass now
Collaborator
Author
|
Thank you! |
heavywatal
added a commit
to heavywatal/bayesplot
that referenced
this pull request
Jan 18, 2024
This is a follow-up of stan-dev#285 and stan-dev#300.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
binsargument to a lot of histogram plots. So far, you could only customize the histogram bins viabinwidthandbreaks, but the often most simple and convenient option to just specify the number of bins via thebinsargument ofggplot2::geom_histogramwas missing so far. This PR resolves this issue.