allow changing size of ridgelines - #224
Conversation
|
Travis still isn't working because it times out, but tests pass locally for me. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 98.58% 98.49% -0.10%
==========================================
Files 31 31
Lines 3969 3975 +6
==========================================
+ Hits 3913 3915 +2
- Misses 56 60 +4
Continue to review full report at Codecov.
|
|
All checks now passing via GitHub actions |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 32 32
Lines 4146 4156 +10
=======================================
+ Hits 4078 4088 +10
Misses 68 68
Continue to review full report at Codecov.
|
avoids too much space but also avoids cutting off the top
…into ridgeline-size
|
Added visual tests and made sure axis expansion is sufficient to avoid cutting off top of the highest ridgeline (I checked plots with few parameters, medium number of parameters, and many parameters). |
tjmahr
left a comment
There was a problem hiding this comment.
Just a couple of questions. Otherwise looks good to me.
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 32 32
Lines 4187 4197 +10
=======================================
+ Hits 4119 4129 +10
Misses 68 68
Continue to review full report at Codecov.
|
Based on this issue reported on the forums
https://discourse.mc-stan.org/t/bayesplot-mcmc-areas-line-and-grid-width-manipulation/16001
I added a
sizeargument tomcmc_areas()andmcmc_areas_ridges()to control the size (thickness) of the ridgelines.