Skip to content

Fix flaky Reactor Netty attributes test - #37303

Open
arnabnandy7 wants to merge 1 commit into
spring-projects:mainfrom
arnabnandy7:fix/reactorNettyAttributes
Open

arnabnandy7 wants to merge 1 commit into
spring-projects:mainfrom
arnabnandy7:fix/reactorNettyAttributes

Conversation

@arnabnandy7

Copy link
Copy Markdown

Summary

Fix the flaky reactorNettyAttributes() test by waiting for Reactor Netty to release the pooled connection before asserting that its request attributes have been cleared.

The response body can complete before connection cleanup finishes. Consequently, the test could inspect the channel while the attributes were still present.

The test now uses HttpClient.doOnDisconnected to observe the connection release and waits for that signal before performing the assertion. Production behavior remains unchanged.

Closes #36589

Testing

Targeted test:

./gradlew :spring-webflux:test --tests "org.springframework.web.reactive.function.client.WebClientIntegrationTests.reactorNettyAttributes"`

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 19, 2026
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 20, 2026
@sbrannen sbrannen added this to the 7.1.x milestone Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine why reactorNettyAttributes() in WebClientIntegrationTests is flaky

3 participants