fix(transformer): enforce max_len in make_transformer_src_tgt_masks - #3086
Open
FinalSunFlower wants to merge 1 commit into
Open
FinalSunFlower wants to merge 1 commit into
FinalSunFlower wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2344.
Problem
In make_transformer_src_tgt_masks, length_to_mask(abs_len) infers its sequence width from abs_len.max(). When a batch is padded to a fixed sequence length or aligned to a hardware boundary where wav_len.max() < 1.0, the resulting key-padding mask width is strictly smaller than src.shape[1], causing shape mismatch errors in downstream multi-head attention layers.
Solution
Explicitly pass max_len=src.shape[1] to length_to_mask when constructing src_key_padding_mask.
Added unit regression test verifying that mask dimensions remain aligned to the full padded sequence width when relative lengths are strictly less than 1.0. The test also executes MultiheadAttention with the generated mask.