Clarify positional encoding length limit errors - #3085
Open
Con-Benksl wants to merge 1 commit into
Open
Con-Benksl wants to merge 1 commit into
Con-Benksl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to #2071, specifically the requested diagnostic for inputs exceeding the positional encoding limit.
PositionalEncodingsilently returns onlymax_lenpositions for a longer input. ASR callers then fail with a tensor-size mismatch that does not identify the configured limit. RaiseValueErrorin the shared module with both the input length and the maximum length, before returning an incomplete encoding.The configured capacity and sinusoidal values stay unchanged. Inputs at the limit remain valid. This does not add support for transcribing arbitrarily long recordings.
Validation on CPU, Python 3.11.15 / PyTorch 2.6.0:
TransformerASRencode/source/target paths. Before the fix: 5 failed, 8 passed. Afterward: 13 passed.git diff --checkpass.The tests use synthetic features and a locally initialized small model. No pretrained models, datasets, GPU execution or full repository test suite were used. Existing mask-type deprecation and attention-test overflow warnings remain.
Implemented and tested autonomously with OpenAI Codex, with independent read-only review by another Codex agent.
Before submitting
PR review
Reviewer checklist