Skip hpopt reporting when no result was provided - #3082
Open
Con-Benksl wants to merge 1 commit into
Open
Con-Benksl wants to merge 1 commit into
Con-Benksl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2358.
Exiting a hyperparameter-optimization context without calling
report_result()reports the initial{"objective": 0.0}placeholder. This raisesKeyErrorwith a custom objective key, including evaluation-only runs, or emits a result that was never measured with the default key.Initialize the pending result to
None, which the existing exit guard already handles. Explicitly reported results, including zero, still go through the selected reporter or generic fallback.Validation:
KeyErrors and 2 unwanted zero reports).pytest tests/unittests/test_hpopt.py --doctest-modules speechbrain/utils/hpopt.py -q: 18 passed. This also checks explicit zero results, last-result selection and context cleanup using the real generic reporter.pre-commit run -aandgit diff --checkpassed.No model downloads or training runs were needed. The full suite and a live Oríon experiment were not run. No new dependencies or API changes.
Implemented and tested with OpenAI Codex, with independent read-only review by another Codex agent.
Before submitting
PR review
Reviewer checklist