Fix attentive statistics pooling dtype mismatch with FP16 and BF16 - #3081
Open
Con-Benksl wants to merge 1 commit into
Open
Con-Benksl wants to merge 1 commit into
Con-Benksl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2544.
With FP16/BF16 inputs and weights,
AttentiveStatisticsPoolingcomputes its global statistics in FP32. Concatenating these statistics with the input promotes the attention input to FP32, so the following half-precision convolution raises a dtype mismatch.Cast the concatenated attention input back to
x.dtype. The global statistics still accumulate at their original precision, and the path without global context is unchanged. No new dependencies or API changes.Validation (CPU, PyTorch 2.6.0):
pre-commit run -a, changed-file pre-commit andgit diff --checkpassed.The full test suite, GPU execution and pretrained-model/training recipes were not run. This fixes the pooling layer's reported mismatch; it does not claim to validate full ECAPA training in half precision.
Implemented and tested with OpenAI Codex, with independent read-only review by another Codex agent.
Before submitting
PR review
Reviewer checklist