fix: resolve deprecated weight_norm in torch - #3075
Draft
Decodetalkers wants to merge 1 commit into
Draft
Decodetalkers wants to merge 1 commit into
Decodetalkers wants to merge 1 commit into
Conversation
Contributor
Author
|
Ok, this place need to use lazy import.. so I need to copy the code for many times.. |
Decodetalkers
force-pushed
the
fix/deprecated_weight_norm
branch
4 times, most recently
from
August 26, 2026 00:33
8bd0fc8 to
58ec9e5
Compare
resolve: speechbrain#3074 This pr induced a file named torch_weight_norm.py, allow to try import the newest one, if failed , fallback to the old one. This logic was from dac.py.
Contributor
Author
|
Is it because the pretrained model itself is using the old torch? |
Decodetalkers
marked this pull request as draft
August 26, 2026 00:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve: #3074
This pr induced a file named torch_weight_norm.py, allow to try import the newest one, if failed , fallback to the old one. This logic was from dac.py, and I made it a separated python file
What does this PR do?
Fixes #3074
Before submitting
PR review
Reviewer checklist