Skip to content

fix: mel_spectogram should be mel_spectrogram - #3063

Merged
pplantinga merged 2 commits into
speechbrain:developfrom
Decodetalkers:typo
Aug 25, 2026
Merged

pplantinga merged 2 commits into
speechbrain:developfrom
Decodetalkers:typo

Conversation

@Decodetalkers

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix a typo of function

mel_spectogram should be mel_spectrogram , it was a typo.. seems they are too many , it becomes a breaking change

https://docs.pytorch.org/audio/main/generated/torchaudio.transforms.MelSpectrogram.html

So I will mark this pr as draft

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ x] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Decodetalkers
Decodetalkers marked this pull request as draft June 30, 2026 03:27
@Decodetalkers
Decodetalkers force-pushed the typo branch 2 times, most recently from d2179aa to 80d949a Compare June 30, 2026 03:36
@Decodetalkers

Decodetalkers commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@pplantinga can you review it? Thanks

@Decodetalkers Decodetalkers reopened this Aug 25, 2026
@Decodetalkers
Decodetalkers marked this pull request as ready for review August 25, 2026 03:00

@pplantinga pplantinga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pplantinga
pplantinga merged commit 2bafd45 into speechbrain:develop Aug 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants