HDF5 integration not loading/caching etc. by Adel-Moumen · Pull Request #3007 · speechbrain/speechbrain

Adel-Moumen · 2025-11-28T18:09:33Z

Added methods to check if a UID is cached, load cached results, and save results to the cache.

What does this PR do?

Regression from #3005 which removed the functions for loading/caching etc. Not sure how we missed this in the review process...

Before submitting

Did you read the contributor guideline?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Does your code adhere to project-specific code style and conventions?

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
Review the self-review checklist to ensure the code is ready for review

Added methods to check if a UID is cached, load cached results, and save results to the cache.

pplantinga

LGTM

wow. how did we missed this?

360fe19

Added methods to check if a UID is cached, load cached results, and save results to the cache.

Adel-Moumen requested a review from pplantinga November 28, 2025 18:12

pplantinga approved these changes Nov 28, 2025

View reviewed changes

pplantinga merged commit b3e80b4 into develop Nov 28, 2025
5 checks passed

pplantinga deleted the fix-hdf5-regression branch November 28, 2025 19:00