Skip to content

Fix to support CV 18 - #2647

Merged
asumagic merged 5 commits into
speechbrain:developfrom
cvl01:fix/support-common-voice-18
Sep 25, 2024
Merged

Fix to support CV 18#2647
asumagic merged 5 commits into
speechbrain:developfrom
cvl01:fix/support-common-voice-18

Conversation

@cvl01

@cvl01 cvl01 commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Currently recipes/CommonVoice/common_voice_prepare.py throws an error when used with Common Voice 18. Seems that the columns used have been changed, a column was added.

This solution tries to be more bullet proof by using the header row and mapping that, to determine the column index.

Fixes # (no issue)

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

Christiaan van Luik
Fix to support CV 18
e8b77cc 
Fix to support CV 18
@cvl01 cvl01 mentioned this pull request Aug 22, 2024
Closed
@asumagic
asumagic self-requested a review September 3, 2024 12:17
@TParcollet

TParcollet commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@asumagic we were talking about it! This sounds like a nice update thanks @cvl01. We might want to avoid adding an extra parameter to the function however.

@asumagic asumagic added this to the v1.1.0 milestone Sep 4, 2024
pplantinga
pplantinga reviewed Sep 14, 2024
View reviewed changes
Comment thread recipes/CommonVoice/common_voice_prepare.py
@asumagic asumagic self-assigned this Sep 25, 2024
@asumagic

asumagic commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

After my fixes, sanity checked on sr 19.0, ka 6.1, en (of whatever unlabelled version we have on this cluster?) and the output CSVs seem correct. CV en training on conformer-transducer runs.

@asumagic
asumagic merged commit 43c2d07 into speechbrain:develop Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pplantinga pplantinga pplantinga left review comments
@asumagic asumagic asumagic approved these changes

Assignees

@asumagic asumagic

Labels

None yet

Projects

None yet

Milestone

v1.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@cvl01 @TParcollet @asumagic @pplantinga