Skip to content

Add Diarization interface and refactor Interfaces with types - #1727

Open
svecjan wants to merge 5 commits into
speechbrain:developfrom
svecjan:diar-interface
Open

svecjan wants to merge 5 commits into
speechbrain:developfrom
svecjan:diar-interface

Conversation

@svecjan

@svecjan svecjan commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

Diarization interface

  • Connect pretrained models from speechbrain/vad-crdnn-libriparty and speechbrain/spkrec-ecapa-voxceleb(only extractor part) from HuggingFace
  • Add loading dataset from dict object
  • Data for test diar interface is on Swabe/diar-vad-ecapa
  • Fix small typos and normalise create str process

Refactor interfaces

  • add types to class and methods headers
  • fix some typos

@svecjan

svecjan commented Dec 3, 2022

Copy link
Copy Markdown
Contributor Author

Probably overlay with PR #1725.

@Adel-Moumen

Copy link
Copy Markdown
Collaborator

Hello @svecjan,

Sorry for the delay.

Do you mind updating this PR with respect to the latests commits in the branch develop please ? We recently merged a lot of PRs that may be in conflict with yours. I think the easiest way to do it would be to create a new PR with SpeechBrain develop and then add your contributions...

Could you please confirm me if you are still fine to finish this PR? Sorry again for the delay.

Best,
Adel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants