Skip to content

Remove unused compiler and javadoc options - #276

Merged
goneall merged 1 commit into
spdx:masterfrom
dwalluck:pom-remove-unused-options
Jan 22, 2025
Merged

goneall merged 1 commit into
spdx:masterfrom
dwalluck:pom-remove-unused-options

Conversation

@dwalluck

@dwalluck dwalluck commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

The optimize tag is deprecated and a noop, and javadoc.opts is not set anywhere.

@dwalluck
dwalluck force-pushed the pom-remove-unused-options branch from 0906759 to 5662538 Compare January 22, 2025 21:19
@dwalluck

Copy link
Copy Markdown
Contributor Author

The previous version of this pull request actually removed too much (the entire execution as opposed to just the configuration).

@bact
bact self-requested a review January 22, 2025 21:24

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
goneall merged commit 9b1ff24 into spdx:master Jan 22, 2025
@dwalluck
dwalluck deleted the pom-remove-unused-options branch January 22, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants