feat: support ThumbHash as placeholder - #12
Open
subframe7536 wants to merge 1 commit into
Open
subframe7536 wants to merge 1 commit into
subframe7536 wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in ThumbHash placeholders alongside the existing inline image and BlurHash previews.
thumbhashis an optional peer dependency and is only imported when this preview type is enabled.Why
ThumbHash is a useful alternative to BlurHash because it:
This implementation keeps the hash as a
Uint8Array, matching the upstreamthumbhashAPI instead of introducing an internal base64 representation.Implementation
{ type: "thumbhash" }to the Vite plugin placeholder options.rgbaToThumbHashfrom an EXIF-corrected, max-100px RGBA sample.thumbHashToDataURL.SolidImageindependent ofthumbhash; generated modules inject the decoder only when needed.remote.transformURL.Uint8Arrayin generated modules.Testing
Validated with:
pnpm install;Coverage includes local and remote placeholders, EXIF orientation, the 100px encoding limit, alpha-aware colors,
Uint8Arrayrestoration, decoder injection, browser decoding, and preview cleanup after image load.