Enable numberparsingcheck and stringparsingcheck on MSVC - #853
Merged
Merged
Conversation
jkeiser
reviewed
May 2, 2020
| #define JSON_TEST_NUMBERS | ||
| #endif | ||
|
|
||
| #ifndef _MSC_VER |
Member
There was a problem hiding this comment.
Future note: we should just bite the bullet and rename dirent_portable.h to dirent.h.
jkeiser
reviewed
May 2, 2020
| endif() | ||
| add_cpp_test(numberparsingcheck LABELS acceptance per_implementation) | ||
| target_link_libraries(numberparsingcheck simdjson-include-source simdjson-windows-headers) | ||
| target_compile_definitions(numberparsingcheck PRIVATE NOMINMAX) |
Member
There was a problem hiding this comment.
Oh wow, this is common enough that they made a specific property for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added include dirent_portable and disabled min/max macros.