Skip to content

chore: fix CI, bump Python version in requirements - #1650

Merged
jku merged 2 commits into
mainfrom
ww/fix-req
Jan 9, 2026
Merged

jku merged 2 commits into
mainfrom
ww/fix-req

Conversation

@woodruffw

Copy link
Copy Markdown
Member

This should unblock #1649.

Signed-off-by: William Woodruff <william@astral.sh>
@woodruffw
woodruffw requested review from di and jku January 8, 2026 23:03
@woodruffw woodruffw self-assigned this Jan 8, 2026
Comment thread .github/workflows/requirements.yml Outdated

- name: Run test install
run: python -m pip install -r install/requirements.txt
run: python -m pip install --no-deps -r install/requirements.txt

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: --no-deps is strictly correct in our case anyways because our requirements are fully hashed here, so all this does is work around pypa/pip#9644

Signed-off-by: William Woodruff <william@astral.sh>
@woodruffw
woodruffw marked this pull request as ready for review January 8, 2026 23:07
@woodruffw woodruffw added the chore label Jan 8, 2026
@woodruffw

Copy link
Copy Markdown
Member Author

NB: Once merged I'll kick off the requirements regeneration workflow to adjust for the new .python-version.

Comment thread install/.python-version
@@ -1 +1 @@
3.9.16
3.10.19

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1645.

@jku jku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jku
jku merged commit 6ea9424 into main Jan 9, 2026
44 checks passed
@jku
jku deleted the ww/fix-req branch January 9, 2026 09:43
@jku

jku commented Jan 9, 2026

Copy link
Copy Markdown
Member

NB: Once merged I'll kick off the requirements regeneration workflow to adjust for the new .python-version.

I'm a bit confused now -- can the workflow be used like this?

@woodruffw

Copy link
Copy Markdown
Member Author

NB: Once merged I'll kick off the requirements regeneration workflow to adjust for the new .python-version.

I'm a bit confused now -- can the workflow be used like this?

I thought so -- it has a workflow_dispatch trigger, I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants