Small samtools stats speed up, ~5%. - #893
Open
jkbonfield wants to merge 3 commits into
Open
jkbonfield wants to merge 3 commits into
jkbonfield wants to merge 3 commits into
Conversation
valeriuo
self-requested a review
July 12, 2018 13:08
valeriuo
approved these changes
Jul 12, 2018
valeriuo
left a comment
Contributor
There was a problem hiding this comment.
I got around 3%, but still good.
…lacial. Time for a small test file dropped from 119s to 43s. (That's still 100x slower than -i 8000 though...) Sadly I've only now noticed that -i 0 is totally undocumented and so I doubt anyone runs it in this manner. (I'm half tempted to remove this complex piece of code entirely!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(NB: No point considering for this release.)
I experimented and got a barely worth it speed increase, but it's there if we want it. No worries if we don't. :-)
This was the biggest single slow down, but the next lot are rather spread around so there isn't one single gain to be had I think (short of a larger overhaul).