Skip to content

feat: print Rsbuild-style URL logs - #81

Merged
chenjiahan merged 6 commits into
mainfrom
server_urls_0227
Feb 28, 2026
Merged

chenjiahan merged 6 commits into
mainfrom
server_urls_0227

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

Prints Rsbuild-style URL logs and removes some verbose logs.

Screenshot 2026-02-27 at 17 18 48

Copilot AI review requested due to automatic review settings February 27, 2026 09:19
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the development server's console output by introducing a modern, Rsbuild-inspired URL logging format and reducing unnecessary verbose messages. It also updates branding references from Webpack to Rspack, ensuring consistency and a cleaner user experience. The changes aim to provide more focused and aesthetically pleasing information to developers during the development process.

Highlights

  • Rsbuild-style URL Logging: Implemented a new, more visually appealing Rsbuild-style format for displaying local and network URLs in the console, utilizing colored text for better readability.
  • Reduced Verbose Logs: Removed several verbose log messages related to static content serving and history API fallback, streamlining the console output.
  • Rspack Branding Update: Updated internal logger names and Bonjour service broadcast names/subtypes from 'webpack' to 'rspack' to align with the Rspack ecosystem.
  • Infrastructure Logging Control: Added a new method shouldLogInfrastructureInfo to control when infrastructure-related information, such as URL logs, should be displayed based on the compiler's infrastructure logging level.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/server.ts
    • Imported styleText utility for colored console output.
    • Changed the infrastructure logger name from 'webpack-dev-server' to 'rspack-dev-server'.
    • Added shouldLogInfrastructureInfo method to determine if infrastructure logs should be displayed.
    • Updated the graceful shutdown message for clarity.
    • Modified Bonjour service name and subtype from 'webpack' to 'rspack'.
    • Removed colorette imports and associated color utility functions.
    • Refactored URL logging logic to adopt the new Rsbuild-style format using styleText.
    • Removed verbose log messages for static content and history API fallback configurations.
    • Updated Bonjour broadcasting log message to reflect the 'rspack' subtype.
  • tests/e2e/bonjour.test.js
    • Updated expected Bonjour service name and subtype in test assertions from 'webpack' to 'rspack' across various test cases.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the server startup logging to adopt an Rsbuild-style format, which improves clarity and conciseness. It also removes some previously verbose log messages and updates branding from 'webpack' to 'rspack' across the codebase, including in tests. The changes are logical and align with the stated goals. I've identified one potential runtime error that could occur if infrastructureLogging is not defined in the compiler options, which I've detailed in a specific comment.

Comment thread src/server.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dev server startup/status logging to match Rsbuild-style URL output and aligns Bonjour/service naming with Rspack branding.

Changes:

  • Replace existing “Project is running at” URL/status logs with Rsbuild-style Local/Network URL lines and remove some verbose status logs.
  • Rename infrastructure logger scope from webpack-dev-server to rspack-dev-server.
  • Update Bonjour advertisement name/subtype from webpack to rspack and adjust related e2e expectations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
tests/e2e/bonjour.test.js Updates expected Bonjour publish payload to Rspack Dev Server and subtype rspack.
src/server.ts Implements new URL log formatting/output, tweaks shutdown message, and updates logger/Bonjour branding strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/server.ts Outdated
Comment thread src/server.ts
Comment thread src/server.ts
Comment thread src/server.ts
Comment thread src/server.ts Outdated
chenjiahan and others added 5 commits February 27, 2026 17:25
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@chenjiahan
chenjiahan merged commit f8a9641 into main Feb 28, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the server_urls_0227 branch February 28, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants