feat: print Rsbuild-style URL logs - #81
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the development server's console output by introducing a modern, Rsbuild-inspired URL logging format and reducing unnecessary verbose messages. It also updates branding references from Webpack to Rspack, ensuring consistency and a cleaner user experience. The changes aim to provide more focused and aesthetically pleasing information to developers during the development process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the server startup logging to adopt an Rsbuild-style format, which improves clarity and conciseness. It also removes some previously verbose log messages and updates branding from 'webpack' to 'rspack' across the codebase, including in tests. The changes are logical and align with the stated goals. I've identified one potential runtime error that could occur if infrastructureLogging is not defined in the compiler options, which I've detailed in a specific comment.
There was a problem hiding this comment.
Pull request overview
Updates the dev server startup/status logging to match Rsbuild-style URL output and aligns Bonjour/service naming with Rspack branding.
Changes:
- Replace existing “Project is running at” URL/status logs with Rsbuild-style Local/Network URL lines and remove some verbose status logs.
- Rename infrastructure logger scope from
webpack-dev-servertorspack-dev-server. - Update Bonjour advertisement name/subtype from webpack to rspack and adjust related e2e expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/e2e/bonjour.test.js |
Updates expected Bonjour publish payload to Rspack Dev Server and subtype rspack. |
src/server.ts |
Implements new URL log formatting/output, tweaks shutdown message, and updates logger/Bonjour branding strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Prints Rsbuild-style URL logs and removes some verbose logs.