Skip to content

refactor: simplify web target check by using compiler.platform.web #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Mar 3, 2026
Merged

refactor: simplify web target check by using compiler.platform.web #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,45 +391,9 @@ class Server<
return path.resolve(dir, 'node_modules/.cache/rspack-dev-server');
}

static isWebTarget(compiler: Compiler): boolean {
if (compiler.platform?.web) {
return compiler.platform.web;
}

// TODO improve for the next major version and keep only `webTargets` to fallback for old versions
if (compiler.options.externalsPresets?.web) {
return true;
}

if (compiler.options.resolve?.conditionNames?.includes('browser')) {
return true;
}

const webTargets: (string | undefined | null)[] = [
'web',
'webworker',
'electron-preload',
'electron-renderer',
'nwjs',
'node-webkit',
undefined,
null,
];

if (Array.isArray(compiler.options.target)) {
return compiler.options.target.some((r: string | undefined | null) =>
webTargets.includes(r),
);
}

return webTargets.includes(
compiler.options.target as string | undefined | null,
);
}

addAdditionalEntries(compiler: Compiler) {
const additionalEntries: string[] = [];
const isWebTarget = Server.isWebTarget(compiler);
const isWebTarget = Boolean(compiler.platform.web);
Comment thread
chenjiahan marked this conversation as resolved.
Comment thread
chenjiahan marked this conversation as resolved.

// TODO maybe empty client
if (this.options.client && isWebTarget) {
Expand Down
Loading