Skip to content

Meta: Validate feature descriptions and functionality - #3621

Merged
yakov116 merged 17 commits into
refined-github:masterfrom
yakov116:test_em_all
Oct 18, 2020
Merged

Meta: Validate feature descriptions and functionality#3621
yakov116 merged 17 commits into
refined-github:masterfrom
yakov116:test_em_all

Conversation

@yakov116

@yakov116 yakov116 commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Feature Name Readme Link Testing Link Tested/Working
action-used-by-link #L328 Link ✔️
align-issue-labels #L207 Link ✔️
batch-mark-files-as-viewed #L240 ✔️
batch-open-conversations #L2013 ✔️
bugs-tab #L216 ✔️
bypass-checks #L234 ✔️
ci-link #L116 ✔️
clean-conversation-filters #L212 ✔️
clean-conversation-headers #L220 ✔️
clean-rich-text-editor #L177 ✔️
clean-sidebar #L211 ✔️
cleanup-repo-filelist-actions #L132 ✔️
clear-pr-merge-commit-message #L256 ✔️
clone-branch #L130 ✔️
close-out-of-view-modals #L322 ✔️
collapsible-content-button #L171 ✔️
comment-fields-keyboard-shortcuts #L174 Link ❌
comments-time-machine-links #L187 ✔️
conflict-marker #L237 ✔️
conversation-filters #L209 ✔️
conversation-links-on-repo-lists #L305 ✔️
convert-release-to-draft #L289 ✔️
copy-file #L157 Link ✔️
copy-on-y #L157 ✔️
create-release-shortcut #L285 ✔️
cross-deleted-pr-branches #L239 Link ✔️
cycle-lists-with-keyboard-shortcuts #L213 ✔️
deep-reblame #L276 ✔️
default-branch-button #L123 ✔️
deprioritize-marketplace-link #L323 ✔️
dim-bots Added ✔️
download-folder-button #L142 ✔️
edit-comments-faster #L173 ✔️
edit-files-faster #L144 ✔️
edit-readme #L145 ✔️
embed-gist-inline #L186 Link ✔️
embed-gist-via-iframe #L344 ✔️
enable-file-links-in-compare-view #L346 ✔️
esc-to-deselect-line #L161 ✔️
expand-all-collapsed-code #L273 ✔️
expand-all-hidden-comments #L196 ✔️
extend-conversation-status-filters #L215 ✔️
extend-diff-expander #L270 ✔️
faster-pr-diff-options #L267 Mostly ❔
faster-reviews #L257 Auto focus not working ❔
file-finder-buffer #L147 ✔️
first-published-tag-for-merged-pr #L241 ✔️
fit-textareas #L172 ✔️
follow-file-renames #L268 ✔️
fork-source-link-same-view #L131 ✔️
forked-to #L126 ✔️
format-conversation-titles NONE ✔️
global-conversation-list-filters #L210 ✔️
go-to-action-from-file #L129 ✔️
hidden-review-comments-indicator #L236 ✔️
hide-comments-faster #L194 ✔️
hide-disabled-milestone-sorter #L339 ✔️
hide-empty-meta #L337 Link ❌
hide-inactive-deployments #L231 Link ✔️
hide-issue-list-autocomplete #L341 ✔️
hide-navigation-hover-highlight #L336 ✔️
hide-own-stars #L312 ✔️
hide-useless-comments #L192 ✔️
hide-useless-newsfeed-events #L313 ✔️
hide-watch-and-fork-count #L119 ✔️
hide-zero-packages Fixed ✔️
highest-rated-comment #L191 ✔️
highlight-collaborators-and-own-conversations #L206 ✔️
highlight-deleted-and-added-files-in-diffs #L277 ✔️
highlight-non-default-base-branch #L229 ✔️
html-preview-link #L162 ✔️
improve-shortcut-help #L329 ✔️
infinite-scroll #L314 ✔️
keyboard-navigation #L197 ✔️
latest-tag-button #L288 ✔️
link-to-file-in-file-history #L269 ✔️
link-to-github-io #L135 ✔️
link-to-prior-blame-line #L345 ✔️
linkify-branch-references #L340 Dont see it ❌
linkify-code #L78 ✔️
linkify-commit-sha #L226 ✔️
linkify-full-profile-readme-title #L357 Link ✔️
linkify-labels-on-dashboard #L347 ✔️
linkify-notification-repository-header #L350 ✔️
linkify-symbolic-links #L158 ✔️
linkify-user-edit-history-popup #L353 ✔️
linkify-user-location #L302 ✔️
list-prs-for-file #L159 ✔️
mark-merge-commits-in-list #L275 ✔️
mark-private-orgs #L298 ✔️
minimize-upload-bar #L176 ✔️
monospace-textareas #L178 ✔️
more-dropdown #L121 ✔️
navigate-pages-with-arrow-keys #L326 ✔️
new-repo-disable-projects-and-wikis #L133 ✔️
one-key-formatting #L175 ✔️
open-all-notifications #L327 ✔️
open-ci-details-in-new-tab #L235 ✔️
open-issue-to-latest-comment #L195 ✔️
parse-backticks #L324 ✔️
patch-diff-links #L265 ✔️
pinned-issues-update-time #L217 ✔️
pr-branch-auto-delete #L254 ✔️
pr-commit-lines-changed #L238 ✔️
pr-filters #L227 ✔️
pr-jump-to-first-non-viewed-file #L242 ✔️
preserve-file-finder-term #L148 ✔️
preserve-whitespace-option-in-nav #L233 ✔️
prevent-duplicate-pr-submission #L354 ✔️
prevent-pr-commit-link-loss #L351 ✔️
preview-hidden-comments #L190 ❌
previous-next-commit-buttons #L232 ✔️
profile-gists-link #L297 ✔️
profile-hotkey #L299 ✔️
pull-request-hotkey #L253 ✔️
quick-mention #L179 ✔️
quick-review-buttons #L250 ✔️
raw-file-link #L266 ✔️
reactions-avatars #L58 ✔️
recently-pushed-branches-enhancements #L343 ✔️
release-download-count #L283 Link ✔️
releases-tab #L284 ✔️
reload-failed-proxied-images #L348 ✔️
remove-checks-tab #L230 ✔️
remove-diff-signs #L271 ✔️
remove-label-faster #L219 ✔️
remove-projects-tab #L117 Link ✔️
repo-age #L127 ✔️
repo-wide-file-finder #L146 ✔️
resolve-conflicts #L41 ✔️
restore-file #L81 ✔️
same-page-definition-jump #L356 ✔️
selection-in-new-tab #L321 ✔️
separate-draft-pr-button #L255 ✔️
set-default-repositories-type-to-sources #L301 ✔️
shorten-links #L189 ✔️
show-associated-branch-prs-on-fork #L149 ✔️
show-names #L188 ✔️
show-open-prs-of-forks #L128 ✔️
show-user-top-repositories #L300 ✔️
show-whitespace #L38 ✔️
sort-conversations-by-update-time #L208 ✔️
sort-milestones-by-closest-due-date #L120 ✔️
split-issue-pr-search-results #L204 ✔️
star-repo-hotkey #L122 ✔️
sticky-sidebar #L134 ✔️
stop-pjax-loading-with-esc #L355 ✔️
stop-redirecting-in-notification-bar #L330 ✔️
submit-review-as-single-comment #L170 ✔️
suggest-commit-title-limit #L272 ✔️
swap-branches-on-compare #L124 ✔️
sync-pr-commit-title #L248 ✔️
tab-to-indent #L169 ✔️
tag-changelog-link #L287 ✔️
tags-dropdown #L286 ✔️
tags-on-commits-list #L274 Link ✔️
toggle-everything-with-alt #L214 ✔️
toggle-files-button #L143 ✔️
trending-menu-item #L325 ✔️
unwrap-useless-dropdowns #L349 ✔️
update-pr-from-base-branch #L249 Sometimes too well ✔️
use-first-commit-message-for-new-prs #L258 ✔️
useful-not-found-page #L320 ✔️
user-local-time #L303 ✔️
user-profile-follower-badge #L296 ✔️
vertical-front-matter #L163 ✔️
view-markdown-source #L156 ✔️
wait-for-build #L61 ✔️
warn-pr-from-master #L251 ✔️
warning-for-disallow-edits #L252 ✔️

@yakov116
yakov116 force-pushed the test_em_all branch 2 times, most recently from 47e26e0 to 1d29f3f Compare October 6, 2020 04:00
@fregante

This comment has been minimized.

Sign in to view
@yakov116

This comment has been minimized.

Sign in to view
@yakov116 yakov116 mentioned this pull request Oct 6, 2020
Merged
@fregante

This comment has been minimized.

Sign in to view
@notlmn

This comment has been minimized.

Sign in to view
@yakov116

This comment has been minimized.

Sign in to view
@fregante

This comment has been minimized.

Sign in to view
@yakov116

This comment has been minimized.

Sign in to view
@yakov116

This comment has been minimized.

Sign in to view
@yakov116 yakov116 added the meta Related to Refined GitHub itself label Oct 7, 2020
@yakov116

This comment has been minimized.

Sign in to view
@yakov116 yakov116 mentioned this pull request Oct 7, 2020
Closed
@fregante

This comment has been minimized.

Sign in to view
@fregante fregante mentioned this pull request Oct 8, 2020
Closed
@yakov116

This comment has been minimized.

Sign in to view
@fregante

This comment has been minimized.

Sign in to view
@yakov116 yakov116 mentioned this pull request Oct 12, 2020
Merged
FloEdelmann
FloEdelmann reviewed Oct 12, 2020
View reviewed changes
Comment thread readme.md Outdated
@fregante

This comment has been minimized.

Sign in to view
@fregante fregante mentioned this pull request Oct 13, 2020
Closed
@kidonng kidonng mentioned this pull request Oct 15, 2020
Merged
@yakov116
yakov116 marked this pull request as ready for review October 16, 2020 20:44
@yakov116

yakov116 commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

ALL TESTED 😅

There are some broken features and readme improvements needed.

fregante
fregante approved these changes Oct 16, 2020
View reviewed changes

@fregante fregante left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯💯

Comment thread readme.md Outdated
Comment thread source/features/hidden-review-comments-indicator.tsx
Comment thread readme.md Outdated
@fregante fregante changed the title Test all features Meta: Validate feature descriptions and functionality Oct 16, 2020
@fregante

fregante commented Oct 16, 2020

Copy link
Copy Markdown
Member

linkify-branch-references

This still works as I use it all the time, but it only applies to isQuickPR if I remember correctly.

@fregante

fregante commented Oct 16, 2020

Copy link
Copy Markdown
Member

I'm surprised that most features still work to be fair :D

@yakov116

yakov116 commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

I'm surprised that most features still work to be fair :D

Me too

@yakov116

yakov116 commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

@fregante can you help me with

Descriptions needing updates

  • more-dropdown Needs to also say about moving the security and insights into the drop down
  • edit-comments-faster (Moves the Edit comment button out of the ... dropdown.) Does not move it any more it makes a copy
  • user-profile-follower-badge needs better description

yakov116
yakov116 commented Oct 16, 2020
View reviewed changes
Comment thread source/features/conflict-marker.tsx Outdated
@yakov116 @fregante
Apply suggestions from code review
a7b9a1f 
Co-authored-by: Federico <me@fregante.com>
@fregante fregante mentioned this pull request Oct 17, 2020
Merged
@fregante

fregante commented Oct 18, 2020

Copy link
Copy Markdown
Member
  • more-dropdown Needs to also say about moving the security and insights into the drop down
Adds useful links to the repository navigation dropdown and moves the "Security" and "Insights" tabs to it as well.
  • edit-comments-faster (Moves the Edit comment button out of the ... dropdown.) Does not move it any more it makes a copy
Lets you edit any comment with one click instead of having to open a dropdown.
  • user-profile-follower-badge needs better description
On profiles, it shows whether the user follows you.

@yakov116

yakov116 commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

linkify-branch-references

This still works as I use it all the time, but it only applies to isQuickPR if I remember correctly.

I still can't seem to find it.

@yakov116

yakov116 commented Oct 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think it's ready to be merged. Feel free to merge.

Good night 😴

@yakov116

yakov116 commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

@fregante merge it?

@yakov116
yakov116 merged commit 017c17b into refined-github:master Oct 18, 2020
@yakov116
yakov116 deleted the test_em_all branch October 18, 2020 23:39
@FloEdelmann FloEdelmann mentioned this pull request Oct 22, 2020
Merged
@fregante

fregante commented Feb 11, 2023

Copy link
Copy Markdown
Member

I'd love to see this done again 🥹 I'm confident a lot of minor features are broken. It'd be easier however to just list the broken ones, like:

@yakov116

yakov116 commented Feb 12, 2023

Copy link
Copy Markdown
Member Author

I will see if I have time now.

@fregante

fregante commented Feb 12, 2023

Copy link
Copy Markdown
Member

Are you already in the new Code Search beta? That's the one we should look at now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann left review comments
@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

meta Related to Refined GitHub itself

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yakov116 @fregante @notlmn @FloEdelmann