Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scan('0', { MATCH: '' })currently omitsMATCH, returning all keys instead of matching only the empty key. The shared argument helpers also affect hash, set, and sorted-set scans.Preserve an explicitly empty pattern in both helpers and add regressions for each. Omitted patterns and non-empty patterns keep their existing behavior.
Validation: both new tests fail before the fix. The 905 command argument/reply tests pass on Node 20, 22, and 24. Build, changed-file lint, and command JSDoc checks pass on Node 24. Native Redis 8.4 checks pass for
scan,hScan,sScan,zScan, andscanIterator; the related repository suites pass 88 tests with one cluster test skipped. The full Docker matrix was not run because host networking is unavailable locally.Checklist
npm testpass with this change (including linting)?No API or documentation change is needed.
Note
Low Risk
Small, targeted fix to optional argument serialization with new unit tests; no auth or data-model changes.
Overview
Fixes scan-family commands dropping an explicit empty
MATCHpattern. Previously{ MATCH: '' }was treated like noMATCHbecause the helpers used truthiness, so Redis saw an unfiltered scan instead ofMATCHwith an empty string.parseScanArgumentsandpushScanArgumentsnow emitMATCHwhenMATCH !== undefined, so empty strings are preserved. OmittedMATCHand non-empty patterns behave as before. The same helpers back SCAN, HSCAN, SSCAN, and ZSCAN.Regression tests cover empty
MATCHforSCANargument parsing andpushScanArguments.Reviewed by Cursor Bugbot for commit 97010cf. Bugbot is set up for automated code reviews on this repo. Configure here.