Conversation
Except `inputmedia.py` classes and `Bot`
That makes all TOs, other application classes still have their tests
dataclasses generated `hash()` does not include `self.__class__` so this is to preserve old behaviour of different classes, having same field level hashes, not being equal
Note: this failure revealed a minor breaking change in how `__eq__()` works, worth documenting and adding to changelog later
Old test for a now breaking change unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5279
Discussed Priorly: #2698
<TODO: follow up on some previous discussion points>