Conversation
Member
|
Thanks! Seems like we have missed this in e1df3c4. Would you mind adopting the same comments and style? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mask the reserved bit in PUSH_PROMISE stream IDs when reading and writing frames, matching the existing handling of GOAWAY and WINDOW_UPDATE. RFC 9113 section 6.6 defines a 31-bit promised stream identifier. Without the mask, a peer-set reserved bit leaks into the parsed ID, and the reserved bit alone bypasses the zero-ID check.
Seven regression cases fail before the fix and cover padded/unpadded parsing, zero-ID rejection, and serialization. Full tests pass with 100% branch coverage; source Ruff and strict mypy checks pass.
Specification: https://www.rfc-editor.org/rfc/rfc9113.html#section-6.6