gh-157495: Avoid Py_MIN()/Py_MAX() side effects - #157591
Merged
Merged
Conversation
Avoid calling Py_MIN() or Py_MAX() with non-trivial functions/expressions since these macros evaluate their arguments twice.
Member
Author
|
@skirpichev: I checked Py_MIN/MAX/ABS calls in the Python code base and I found a few calls which are inefficient. I wrote this PR to fix them. |
methane
approved these changes
Sep 16, 2026
Member
Author
|
The duplicated safe_get_max_fd() and _PyDeadline_Get() is not great, but I don't think that it's worth it to backport this change. It's not a big deal to call these functions twice. |
Member
Author
|
Merged. Thanks for the review @methane! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid calling Py_MIN() or Py_MAX() with non-trivial functions/expressions since these macros evaluate their arguments twice.