Conversation
PyWriterWriter_Finish() is not called, the writer is always discarded. It's just used as a temporary buffer. Add non-ASCII tests to test_string_literals.
Member
Author
|
@lysnikolaou @pablogsal: I was surprised that test_string_literals has no test on non-ASCII string. Is it on purpose? The test docstring says:
|
Member
Hummmm I don't think this is on purpose :( |
Member
Author
Oh ok. Well, my PR adds some tests on Unicode characters :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyWriterWriter_Finish() is not called, the writer is always discarded. It's just used as a temporary buffer.
Add non-ASCII tests to test_string_literals.