[3.15] gh-155974: Restore the window attributes when a curses write fails (GH-155975) - #156136
Merged
Merged
Conversation
…ils (pythonGH-155975) addstr(), addnstr(), insstr() and insnstr() set the window rendition to the caller's attr, write, then restore the previous rendition. Since 30dde1e the restore sits below an early return taken when the write fails, so a failed write leaves the caller's attr on the window and drops whatever the application had set with attrset(). Restore the rendition first and report the write error afterwards. A wattrset() failure is still reported when the write itself succeeded. (cherry picked from commit 83531fd) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com>
This was referenced Aug 20, 2026
serhiy-storchaka
approved these changes
Aug 20, 2026
Member
|
@fedonman @serhiy-storchaka This has lots of test failures like: ERROR: test_output_string_attr_restored (test.test_curses.TestCurses.test_output_string_attr_restored) [window.addstr]
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/runner/work/cpython/cpython/Lib/test/test_curses.py", line 445, in test_output_string_attr_restored
self.assertEqual(win.getattrs(), curses.A_UNDERLINE)
^^^^^^^^^^^^
AttributeError: '_curses.window' object has no attribute 'getattrs' |
window.getattrs() is new in 3.16. Write a cell with the window's current rendition and read it back with inch() instead.
Member
|
|
Member
|
Don't forget to edit the commit message before merging and remove the second commit. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addstr(), addnstr(), insstr() and insnstr() set the window rendition to
the caller's attr, write, then restore the previous rendition. Since
30dde1e the restore sits below an early return taken when the write
fails, so a failed write leaves the caller's attr on the window and
drops whatever the application had set with attrset().
Restore the rendition first and report the write error afterwards. A
wattrset() failure is still reported when the write itself succeeded.
(cherry picked from commit 83531fd)
Co-authored-by: Vyron Vasileiadis hi@fedonman.com
addstrno longer restores the window attributes when the write fails #155974