gh-144206: Improve error messages for buffer overflow in fcntl.fcntl() and fcntl.ioctl()#144273
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom Jan 29, 2026
Merged
Conversation
…fcntl() and fcntl.ioctl()
vstinner
reviewed
Jan 27, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Jan 27, 2026
| PyErr_SetString(PyExc_SystemError, "buffer overflow"); | ||
| PyErr_SetString(PyExc_SystemError, | ||
| "Possible stack corruption in fcntl() due to " | ||
| "buffer overflow. " |
Member
There was a problem hiding this comment.
Why do you use a different message for the memcmp() case? It's not a "Memory corruption" here as well?
Member
Author
There was a problem hiding this comment.
It depends whether the buffer was on the stack or in the heap memory (preallocated bytes object).
Member
Author
There was a problem hiding this comment.
It depends whether the buffer was on the stack or in the heap memory (preallocated bytes object).
Member
There was a problem hiding this comment.
Oh ok, it makes sense. I didn't notice that one code path allocated memory on the stack.
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…fcntl() and fcntl.ioctl() (pythonGH-144273)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.