-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-142518: Document thread-safety guarantees of list operations #142519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fd400f0
gh-142518: Document thread-safety guarantees of list operations
lysnikolaou 38483c9
Address feedback; add more details
lysnikolaou cc5c2f0
Merge branch 'main' into list-thread-safety-docs
lysnikolaou 2292896
Add everything to code blocks
lysnikolaou 2b9e711
Improve wording around atomicity; specify exact types
lysnikolaou 688b25a
Better explain lock-free and atomicity
lysnikolaou 11e8072
Use correct ref for atomic
lysnikolaou 8728c54
Merge branch 'main' into list-thread-safety-docs
lysnikolaou f09430b
Fix lint error
lysnikolaou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use correct ref for atomic
- Loading branch information
commit 11e807236914b63b54b5bf6f24a58a95363ead77
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is safe in the sense that it won't corrupt the list, but should we also mention that it results in a race condition?