Add ES|QL lexer - #2876
Add ES|QL lexer#2876styx0x6 wants to merge 18 commits into
Conversation
|
As I didn't know how to manage that, I let an empty placeholder to fill according to the version it will be integrated (2.20?). esql.py => I can commit an update if requested. Let me know. |
|
Hello @Anteru, do you plan any merge within a 2.20 release? Else, when do you plan it? I already would like to update the lexer with Elastic 8.18 updates, so just to know if I wait the merge to work on it or if I can do it now. |
|
As I see you are working on it @Anteru, I will submit a new PR when I'll have time to work on it with 8.x updates et 9 preview updates. Let's merge a first version based on 8.17. |
|
Well, we all try to work here best we can, but busy times sometimes means the project doesn't see much action. |
|
Overall, this looks pretty good, thanks for the contribution! Can you please address the check failures? Nothing major, but some cleanup is needed. |
|
I'll take a look asap. |
|
Hi @Anteru, I committed some fixes that should set issues. Could you please re-run the build checklist? |
|
Sure, let's give it a try. Note you can also run this locally using |
|
Sure, did it. Just missed to update mapfiles. It should be ok now, if think you can validate build tests again. |
|
And the last one I hope :) There was a nomenclature issue in the module name underlining. Let's give the final try @Anteru ? |
|
Hi @Anteru , Do you think we might be able to go ahead with this merge? |
|
Hi @Anteru and @birkenfeld , As I see you're back to work on 2.20 release, any chance to go ahead with this merge? Work seems to be done last time (summer 2025), the final CI Check/review has just to be run on your side. Then I could also quickly go ahead on PR #2968 as it's based on this one. Thank you in advance! |
|
Hi @Anteru and @birkenfeld , As I see you're directly working on the 2.21 release, any chance to be merged this time? Then, as mentioned, I can go ahead on PR #2968 as it's based on this one. Thank you in advance! |
|
Hi @birkenfeld @Anteru , Do you plan to merge this new lexer in 2.21? |
|
Hi @birkenfeld @Anteru , I just saw that version 2.21 has been released. A lot of great work has been done on bugfixes and optimization, however, I'm wondering about the addition of new lexers. Some newer ones have been added, while older ones, like this one, are still pending. Is there any specific policy or set of guidelines regarding the selection of lexers that are included? Do you require to create an issue for new lexers? Perhaps you have additional questions about the relevance of this lexer that I could answer? Thank you in advance. |
This pull request introduces a new lexer to support Elasticsearch Query Language (ES|QL), a piped language which allows to chain together multiple commands to query data in Kibana.
Based on Elasticsearch 8.17.