pre-commit · chriskuehl · May 25, 2018 · May 24, 2018 · May 25, 2018 · chriskuehl
diff --git a/.gitignore b/.gitignore
@@ -6,6 +6,7 @@
 /.idea
 /.project
 /.pydevproject
+/.pytest_cache
 /.tox
 /.venv.touch
 /venv*

diff --git a/pre_commit_mirror_maker/all/.pre-commit-hooks.yaml b/pre_commit_mirror_maker/all/.pre-commit-hooks.yaml
@@ -4,3 +4,4 @@
     language: {language}
     '{match_key}': {match_val}
     args: {args}
+    additional_dependencies: {additional_dependencies}
diff --git a/pre_commit_mirror_maker/languages.py b/pre_commit_mirror_maker/languages.py
@@ -22,8 +22,28 @@ def python_get_package_versions(package_name):
     return list(reversed(versions))
 
 
+def rust_get_package_versions(package_name):
+    url = f'https://crates.io/api/v1/crates/{package_name}'
+    resp = json.load(urllib.request.urlopen(url))
+    return list(reversed([version['num'] for version in resp['versions']]))
+
+
+def node_get_additional_dependencies(package_name, package_version):
+    return [f'{package_name}@{package_version}']
+
+
+def rust_get_additional_dependencies(package_name, package_version):
+    return [f'cli:{package_name}:{package_version}']
+
+
 LIST_VERSIONS = {
     'node': node_get_package_versions,
     'python': python_get_package_versions,
     'ruby': ruby_get_package_versions,
+    'rust': rust_get_package_versions,
+}
+
+ADDITIONAL_DEPENDENCIES = {
+    'node': node_get_additional_dependencies,
+    'rust': rust_get_additional_dependencies,
 }
diff --git a/pre_commit_mirror_maker/make_repo.py b/pre_commit_mirror_maker/make_repo.py
@@ -1,8 +1,10 @@
+import json
 import os.path
 import subprocess
 
 import pkg_resources
 
+from pre_commit_mirror_maker.languages import ADDITIONAL_DEPENDENCIES
 from pre_commit_mirror_maker.languages import LIST_VERSIONS
 
 
@@ -41,11 +43,20 @@ def format_files(src, dest, **fmt_vars):
             file_obj.write(output_contents)
 
 
-def _commit_version(repo, *, language, version, **fmt_vars):
+def _commit_version(
+        repo, *, language, version, additional_dependencies, **fmt_vars,
+):
     # 'all' writes the .version and .pre-commit-hooks.yaml files
     for lang in ('all', language):
         src = pkg_resources.resource_filename('pre_commit_mirror_maker', lang)
-        format_files(src, repo, language=language, version=version, **fmt_vars)
+        format_files(
+            src,
+            repo,
+            language=language,
+            version=version,
+            additional_dependencies=additional_dependencies,
+            **fmt_vars,
+        )
 
     hooks_yaml = os.path.join(repo, 'hooks.yaml')
     if os.path.exists(hooks_yaml):
@@ -73,6 +84,19 @@ def make_repo(repo, *, language, name, **fmt_vars):
         versions_to_apply = package_versions
 
     for version in versions_to_apply:
+        if language in ADDITIONAL_DEPENDENCIES:
+            additional_dependencies = ADDITIONAL_DEPENDENCIES[language](
+                name,
+                version,
+            )
+        else:
+            additional_dependencies = []
+
         _commit_version(
-            repo, name=name, language=language, version=version, **fmt_vars,
+            repo,
+            name=name,
+            language=language,
+            version=version,
+            additional_dependencies=json.dumps(additional_dependencies),
+            **fmt_vars,
         )
diff --git a/pre_commit_mirror_maker/node/.pre-commit-hooks.yaml b/pre_commit_mirror_maker/node/.pre-commit-hooks.yaml
diff --git a/pre_commit_mirror_maker/rust/Cargo.toml b/pre_commit_mirror_maker/rust/Cargo.toml
@@ -0,0 +1,7 @@
+[package]
+name = "__fake_crate"
+version = "0.0.0"
+
+[[bin]]
+name = "__fake_cmd"
+path = "main.rs"
diff --git a/pre_commit_mirror_maker/rust/main.rs b/pre_commit_mirror_maker/rust/main.rs
@@ -0,0 +1 @@
+fn main() {{}}
diff --git a/setup.py b/setup.py
@@ -34,10 +34,10 @@
             'all/.pre-commit-hooks.yaml',
             'all/.version',
             'node/.npmignore',
-            'node/.pre-commit-hooks.yaml',
             'node/*',
             'python/*',
             'ruby/*',
+            'rust/*',
         ],
     },
 )
diff --git a/tests/languages_test.py b/tests/languages_test.py
@@ -3,6 +3,7 @@
 from pre_commit_mirror_maker.languages import node_get_package_versions
 from pre_commit_mirror_maker.languages import python_get_package_versions
 from pre_commit_mirror_maker.languages import ruby_get_package_versions
+from pre_commit_mirror_maker.languages import rust_get_package_versions
 
 
 def assert_all_text(versions):
@@ -29,3 +30,10 @@ def test_ruby_get_package_version_output():
     ret = ruby_get_package_versions('scss-lint')
     assert ret
     assert_all_text(ret)
+
+
+@pytest.mark.integration
+def test_rust_get_package_version_output():
+    ret = rust_get_package_versions('clap')
+    assert ret
+    assert_all_text(ret)
diff --git a/tests/make_repo_test.py b/tests/make_repo_test.py
@@ -65,6 +65,7 @@ def test_commit_version(in_git_dir):
         '.',
         version='0.24.1', language='ruby', name='scss-lint', entry='scss-lint',
         match_key='files', match_val=r'\.scss$', args='[]',
+        additional_dependencies=[],
     )
 
     # Assert that our things got copied over
@@ -84,6 +85,7 @@ def test_arguments(in_git_dir):
         '.',
         version='0.6.2', language='python', name='yapf', entry='yapf',
         match_key='files', match_val=r'\.py$', args='["-i"]',
+        additional_dependencies=['scikit-learn'],
     )
     contents = in_git_dir.join('.pre-commit-hooks.yaml').read()
     assert yaml.safe_load(contents) == [{
@@ -93,6 +95,7 @@ def test_arguments(in_git_dir):
         'language': 'python',
         'files': r'\.py$',
         'args': ['-i'],
+        'additional_dependencies': ['scikit-learn'],
     }]
 
 
@@ -213,3 +216,24 @@ def test_python_integration(in_git_dir):
     subprocess.check_call((sys.executable, 'setup.py', 'egg_info'))
 
     # TODO: test that the package is installable
+
+
+@pytest.mark.integration
+def test_rust_integration(in_git_dir):
+    make_repo(
+        '.',
+        language='rust', name='shellharden', entry='shellharden',
+        match_key='types', match_val='shell', args='["--replace"]',
+    )
+    # Our files should exist
+    assert in_git_dir.join('.version').exists()
+    assert in_git_dir.join('.pre-commit-hooks.yaml').exists()
+    assert in_git_dir.join('Cargo.toml').exists()
+    assert in_git_dir.join('main.rs').exists()
+
+    # Should have made _some_ tags
+    assert _cmd('git', 'tag', '-l')
+    # Should have made _some_ commits
+    assert _cmd('git', 'log', '--oneline')
+
+    # TODO: test that the package is installable