Fix #5613: contours.size ignored on initialization - #5760
Open
maram-odoo wants to merge 1 commit into
Open
maram-odoo wants to merge 1 commit into
maram-odoo wants to merge 1 commit into
Conversation
When passing contours=dict(size=0.25) to go.Contour(), the size was stored in Python but lost during the initial render because the default autocontour=True in plotly.js auto-generates contour levels from ncontours and ignores contours.size. Setting autocontour=False when the user provides contours.size (without explicitly setting autocontour) ensures the size is preserved in the serialized JSON and honored on first render. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contours=dict(size=0.25)togo.Contour(), thesizewas stored correctly in Python (c.contours.size == 0.25) but lost during the initial render because plotly.js defaultsautocontourtoTrue, which auto-generates contour levels fromncontoursand ignorescontours.size.autocontour=Falseautomatically when the user providescontours.size(or other explicit contour level attributes likestart/end) without explicitly settingautocontour, ensuring the size is preserved in the serialized JSON and honored on first render.autocontouris explicitly set by the user, or when no explicit contour attributes are provided (defaultautocontour=None→ JS default ofTrueis preserved for backward compatibility).Test plan
go.Contour(z=[[1,2],[3,4]], contours=dict(size=0.25))now serializesautocontour: falseandcontours.size: 0.25in the JSONgo.Contour(z=[[1,2],[3,4]], contours=dict(size=0.25), autocontour=False)still worksgo.Contour(z=[[1,2],[3,4]])(no contours) preserves default behaviorgo.Contour(z=[[1,2],[3,4]], autocontour=True, ncontours=5)still worksgo.Figure(data=[go.Contour(...)])serializes correctly🤖 Generated with Claude Code