Conversation
Korbeil
force-pushed
the
feature/phpdoc-handle-union-on-nullable
branch
from
October 26, 2021 19:02
1121c9c to
15d0179
Compare
JanTvrdik
reviewed
Oct 26, 2021
Korbeil
force-pushed
the
feature/phpdoc-handle-union-on-nullable
branch
from
October 26, 2021 20:03
15d0179 to
ffa44f7
Compare
Author
|
I didn't tested it and now I see that is no valid syntax (see https://3v4l.org/r7KOM) so I can understand the 👎 |
Member
|
Yeah, it's definitely better to update the Symfony code in this case. |
Author
|
Closing this PR as this is no valid PHP syntax, we'll just ignore this syntax in the Symfony extractor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on symfony/symfony#40457 to introduce this parser as the default extractor for Symfony. And one of the actual tests (https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php#L86-L89) contains a PhpDoc with
@var ?string|int.And the only remaining issue I have on this extractor is that PhpStan can't parse correctly nullable union types !
Here is the output with the latest version of
phpstan/phpdoc-parser:So this PR introduce a fix to make this parser work correctly with nullable union types