Specify service micro version - #177
Merged
Merged
Conversation
Collaborator
Author
|
@jamiehannaford sorry for bombarding you with PRs |
jamiehannaford
requested changes
Nov 21, 2017
jamiehannaford
left a comment
Contributor
There was a problem hiding this comment.
overall lgtm, just a few minor nits 👍
| 'handler' => $stack, | ||
| ]; | ||
|
|
||
| if ($microVersion) { |
Contributor
There was a problem hiding this comment.
I think this needs to be $serviceType && $microVersion
| } | ||
|
|
||
| private function httpClient(string $baseUrl, HandlerStack $stack): ClientInterface | ||
| private function httpClient(string $baseUrl, HandlerStack $stack, string $serviceType, string $microVersion = null): ClientInterface |
Contributor
There was a problem hiding this comment.
$serviceType can also be null right?
| 'type' => self::STRING_TYPE, | ||
| 'sentAs' => 'user_id', | ||
| 'location' => self::QUERY | ||
| ]; |
Contributor
There was a problem hiding this comment.
maybe add a brief description saying that this refines keypairs by ownership
Collaborator
Author
|
Pushed 😃 |
jamiehannaford
approved these changes
Nov 21, 2017
Contributor
|
Thanks @haphan!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, for backward compatibility, OpenStack API chooses the minimum supported version.
This also means certain features won't be available until a specified version is set in API calls via header, e.g
OpenStack-API-Version: compute 2.17;This PR allows SDK users to specify micro-version of a given service.
Usage: