feat: build more versions on release - #92
Merged
carlos-granados merged 2 commits intoJul 1, 2026
Merged
carlos-granados merged 2 commits into
carlos-granados merged 2 commits into
Conversation
carlos-granados
force-pushed
the
feature/update-release-job
branch
3 times, most recently
from
June 18, 2026 18:08
91d441f to
4f15fdd
Compare
carlos-granados
marked this pull request as draft
June 18, 2026 18:14
carlos-granados
force-pushed
the
feature/update-release-job
branch
2 times, most recently
from
June 18, 2026 18:51
47a7172 to
8bcdb64
Compare
carlos-granados
marked this pull request as ready for review
June 18, 2026 19:00
pronskiy
reviewed
Jun 29, 2026
| $dll = Get-ChildItem -Path $env:RUNNER_TEMP -Recurse -Filter 'php_php_debugger.dll' -ErrorAction SilentlyContinue | Select-Object -First 1 | ||
| if (-not $dll) { | ||
| $dll = Get-ChildItem -Recurse -Filter 'php_php_debugger.dll' -ErrorAction SilentlyContinue | Select-Object -First 1 | ||
| $assetName = "php_php_debugger-php${phpVer}-${tsTag}-windows-x64.dll" |
Member
There was a problem hiding this comment.
This seems inconsistent with macos and linux assets naming, isn't it?
ASSET_NAME="php-debugger-php${PHP_VER}-${TS_TAG}-${OS_TAG}-${ARCH_TAG}.so"
$assetName = "php_php_debugger-php${phpVer}-${tsTag}-windows-x64.dll"
Collaborator
Author
There was a problem hiding this comment.
By convention PHP extension DLLs in Windows have a name that starts with php_ but the second _ should have been a - to match the Linux/MacOs assets, updated
carlos-granados
force-pushed
the
feature/update-release-job
branch
from
June 30, 2026 13:38
8f6d3b9 to
44bd20d
Compare
pronskiy
approved these changes
Jul 1, 2026
carlos-granados
force-pushed
the
feature/update-release-job
branch
from
July 1, 2026 20:19
44bd20d to
f221b8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample release in my fork: https://github.com/carlos-granados/php-debugger/releases/tag/test