refactor: remove all code for PHP versions lower than 8.2 - #69
Merged
carlos-granados merged 1 commit intoMay 3, 2026
Merged
carlos-granados merged 1 commit into
carlos-granados merged 1 commit into
Conversation
pronskiy
reviewed
May 2, 2026
| # pragma GCC diagnostic push | ||
| # pragma GCC diagnostic ignored "-Wdeclaration-after-statement" | ||
| # endif | ||
| # include "zend_enum.h" |
Member
There was a problem hiding this comment.
As I understand, this is now under if !defined(_MSC_VER), isn't it? Same below
Collaborator
Author
There was a problem hiding this comment.
Yeah, I removed the wrong #endif, did not notice it because under linux this compiles fine, only noticed it when the code was compiled in Windows in CI. Now fixed
carlos-granados
force-pushed
the
refactor/remove-code-below-8.2
branch
from
May 2, 2026 21:40
a237607 to
4475810
Compare
# Conflicts: # src/base/base.c # Conflicts: # src/base/base.c
carlos-granados
force-pushed
the
refactor/remove-code-below-8.2
branch
from
May 2, 2026 22:00
1b57087 to
554155a
Compare
pronskiy
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all remaining code that targeted versions of PHP lower than 8.2, which is the lowest version that we support