fix: potential security issues - #49
Merged
Merged
Conversation
…t number conversion
…`ip_info.c` ⏺ Fixed ip_info.c:204 by: 1. Bounding the sscanf %s with a width specifier (%IF_NAMESIZE s via stringification macros). 2. Enlarging the local iface buffer to IF_NAMESIZE + 1 so the width-bounded write + null terminator fits safely. 3. Replacing strcpy(interface, iface) with a bounded strncpy + explicit null-termination, since the caller-provided interface buffer is IF_NAMESIZE.
… cross-platform compatibility in `timing.c`.
…nd` in file locking logic. Instead of calling freopen(tmp_fname, "w", fh) — which re-resolves the path and could open a different file than the one we stat'd and locked — we now truncate the already-locked file descriptor directly via ftruncate(fileno(fh), 0) and rewind. The operation now targets the same inode we hold the exclusive flock on, so a path swap between check and use can no longer redirect the write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.