Skip to content

Fix warnings raised by the compiler - #46

Merged
carlos-granados merged 4 commits into
php-debugger:mainfrom
carlos-granados:fix/compiler-warnings
Apr 19, 2026
Merged

carlos-granados merged 4 commits into
php-debugger:mainfrom
carlos-granados:fix/compiler-warnings

Conversation

@carlos-granados

Copy link
Copy Markdown
Collaborator
  • When running the tests compile the code with warnings using the --enable-php-debugger-dev flag when configuring (this flag has been renamed from the old --enable-xdebug-dev name
  • Fix existing warnings which had not been found because we had not been using this option, mainly removes unused functions and variables and makes sure that variable declaration is not mixed with code
  • Apply two new warnings -Wstrict-prototypes and -Wold-style-definition and fix the issues found by them

This is probably better reviewed by looking at the individual commits

Note: I was not able to apply the -Wmissing-prototypes warning because our code uses several Zend macros which define functions without adding a prototype

@pronskiy

Copy link
Copy Markdown
Member

Lgtm 👍

@carlos-granados
carlos-granados merged commit 1cd4ef3 into php-debugger:main Apr 19, 2026
13 of 15 checks passed
@carlos-granados
carlos-granados deleted the fix/compiler-warnings branch April 19, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants