Skip to content

refactor: remove init_oparray function - #38

Merged
carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:feature/remove-init-op-array
Apr 7, 2026
Merged

carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:feature/remove-init-op-array

Conversation

@carlos-granados

Copy link
Copy Markdown
Collaborator

The xdebug_init_oparray function did not have any functionality after removing all the additional modes. This function was called every time an oparray was constructed. This PR removes this function and the handler call in the extension which should improve performance a little

@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 4, 2026
@carlos-granados
carlos-granados requested a review from pronskiy April 4, 2026 13:40
@pronskiy

pronskiy commented Apr 7, 2026

Copy link
Copy Markdown
Member

nitpick:
i'd prefix with refactor: as it does not add any features.

lgtm, rebase and merge 🫡

@carlos-granados
carlos-granados force-pushed the feature/remove-init-op-array branch from 77eea57 to cb28618 Compare April 7, 2026 23:05
@carlos-granados carlos-granados changed the title feat: remove init_oparray function refactor: remove init_oparray function Apr 7, 2026
@carlos-granados
carlos-granados merged commit 6b0b321 into php-debugger:main Apr 7, 2026
11 checks passed
@carlos-granados
carlos-granados deleted the feature/remove-init-op-array branch April 7, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants