Throw when the size does not fit into an int in PharFileInfo::getCompressedSize() - #23719

Hi. Thanks for the PR. Several questions:

1. Do you think this as a bugfix should target lower branches?
2. Perhaps a better PR title?
3. While at it, are there similar bugs in the extension? From the first glance I think there may be. But I might be wrong.
4. Can you add tests if applicable? Also perhaps NEWS?

Code wise I think this is correct.

There are many such instances and people deal with negative values routinely. So I don't see why this (and other such issues) should be fixed.

I am not very sure about the convention here. But I do find many such instance in the code base (getSize()、filesize() and stat() and perhaps mount()).

Also if you are going to throw an exception don't use an SPL Exception (expecially one that makes no sense)

Can you explain the reason here? I am not familiar with SPL Exception so I can't tell why but I am willing to know, because I see some usage of this in the code base.

There are many such instances and people deal with negative values routinely. So I don't see why this (and other such issues) should be fixed.

I am not very sure about the convention here. But I do find many such instance in the code base (getSize()、filesize() and stat() and perhaps mount()).

Instance that throw an error if a u32 does not fit in a zend_long? I'm not sure I understand the sentence correctly.

Also if you are going to throw an exception don't use an SPL Exception (expecially one that makes no sense)

Can you explain the reason here? I am not familiar with SPL Exception so I can't tell why but I am willing to know, because I see some usage of this in the code base.

SPL exceptions are just bad, but also one shouldn't be throwing an exception from a different extension Phar, expecially for Phar related errors, PharException exists for a reason. Moreover our coding style policy says:

An extension MUST NOT throw exceptions that it did not define itself, except for the global TypeError or ValueError exceptions thrown during parameter parsing and parameter validation, and (subclasses of) exceptions that are already defined to be thrown by a class that is subclassed itself. If an extension uses external functionality that may throw an exception it MUST wrap any exception thrown by that functionality into an appropriate exception of its own. It MUST set the $previous property to the original exception when doing so.

See also #21766