Enable pylint and flake8 warnings - #73
Conversation
e019027 to
0aa089f
Compare
0aa089f to
ee6e929
Compare
|
Aw man, I really wish you hadn't chosen such a small line length limit. 80 characters just seems unnecessary these days :-/ |
|
It turned out that 80 characters is almost the maximum that can be displayed side by side without compromising readability on my editor of choice on a full HD monitor. So for this reason I'd like to stick to 80 characters. Myself I do find it limiting sometimes, but not enough to consider to switch. Sorry for declining your suggestion. |
|
Alright, I'll learn to live with it I guess :-) |
|
There's autopep8, but I found it wraps lines at "wrong" places, so this time I did it manually. |
|
I'm asking because I thought a few things were wrapped very weirdly. Would you be open to a couple small changes in that regard? |
|
Could you give some links? |
|
preprocess.py:131 or preprocess.py:224 for example, I think they'd look better when wrapped earlier. Or in preprocess_qch.py I'd move the |
|
Agreed. |
|
Great, then I'll do a PR sometime. |
No description provided.