fix(helpers): silence unused frames at the end of audio streams - #3880
Open
LittleYier wants to merge 1 commit into
Open
LittleYier wants to merge 1 commit into
LittleYier wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The fix has comprehensive regression coverage and no unresolved review issues.
Pull request overview
Updates LocalAudioPlayer.play_stream() to zero-fill unused audio frames at EOF and adds regression coverage.
Changes:
- Zero-fill remaining callback frames before stopping playback.
- Add hardware-independent EOF regression tests.
File summaries
| File | Description |
|---|---|
tests/test_local_audio_player_eof.py |
Tests EOF behavior across stream boundary cases. |
src/openai/helpers/local_audio_player.py |
Silences unused output frames at EOF. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-fill unused frames at EOF in
LocalAudioPlayer.play_stream()to avoid leaving them uninitialized before stopping. Added regression tests.