Skip to content

Prevent stack overflow on recursive schemas #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mromaszewicz merged 5 commits into from
Sep 17, 2026
Merged

Prevent stack overflow on recursive schemas #2543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11a28b1
Prevent stack overflow on recursive schemas
tobio Aug 26, 2026
f9de283
Preserve recursive schema shape via back-ref substitution
tobio Aug 26, 2026
e1ba901
Address review nits: single quotes + unwrapped comments
tobio Sep 1, 2026
cc1f947
Merge remote-tracking branch 'upstream/main' into stack-overflow
mromaszewicz Sep 17, 2026
c89b990
fix: generate concrete recursive types for self-composing allOf
mromaszewicz Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/test/schemas/recursive/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
// Package schemasrecursive exercises recursive and cyclic schema patterns:
// self-referencing types via additionalProperties (issue #52), cyclic oneOf
// references (issue #936, requires circular-reference-limit), and recursive
// $ref inside allOf (issue #1373). All cases are models-only; the point is
// that code generation and compilation succeed without infinite loops.
// references (issue #936, requires circular-reference-limit), recursive $ref
// inside allOf (issue #1373), and allOf compositions whose members refer back
// into a body still being generated (issue #2542, in its object, union,
// transitive, mutual and bystander forms). All cases are models-only; the
// point is that code generation and compilation succeed without infinite
// loops, and that a recursive composition keeps both halves of the allOf.
package schemasrecursive

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml spec.yaml
Loading