Skip to content

fix: follow-ups to #1957 - #1971

Closed
jamietanna wants to merge 1 commit into
mainfrom
iss-1957
Closed

jamietanna wants to merge 1 commit into
mainfrom
iss-1957

Conversation

@jamietanna

Copy link
Copy Markdown
Member

No description provided.

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd hoped that #1610 had fixed this, but unfortunately not - need to keep digging

@jamietanna

Copy link
Copy Markdown
Member Author

#1981 is required for this

@jamietanna

Copy link
Copy Markdown
Member Author

OK, the issue I'm trying to fix is that:

  • IsGoTypeReference needs to get called as part of the AllOf merging, but isn't - so we're calling valueWithPropagatedRef which then returns the value, not a $ref

@mromaszewicz

Copy link
Copy Markdown
Member

Closing — the follow-ups landed via commit cc72767e and PR #2042 (commit 702cc917); a repro confirms x-go-type + x-go-type-skip-optional-pointer together work correctly in allOf. Test infrastructure from this PR is partially merged via commits b4a1b00c and cc72767e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants