Conversation
jorenham
force-pushed
the
typing/fromfunction/shape-typing
branch
from
September 17, 2026 21:39
5654309 to
50121b3
Compare
jorenham
force-pushed
the
typing/fromfunction/shape-typing
branch
from
September 17, 2026 21:42
50121b3 to
825ac55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.fromfunctionnow requires thefunctionsignature to match theshaperank type. This makes it a lot less type-unsafe, at the cost of this now also rejecting technically-validshapesequence types that aren'ttuple[int, ...]orlist[int], which I think is a fair restriction. So let's hope thatmypy_primerwon't get angry :P. But it's a surprisingly unpopular function (according to my shape-typing / popularity gist), so I don't expect this to cause a lot of issues.Pair programmed with AI (and me; a real human!)