BUG: use same-kind casting for the np.searchsorted sorter argument - #32668
Merged
seberg merged 4 commits intoSep 18, 2026
Merged
Conversation
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
…onversion Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
Member
Author
|
The wheel bulder is a failure to upload artifacts after building so not related to the PR. |
seberg
reviewed
Sep 18, 2026
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
Member
Author
|
These 4 PRs that I'm doing about same-kind casting are not backport candidates right? I guess it wouldn't be nice to relax casting in a patch release. |
Member
|
Hmmmm, no very strong opinion either way for these. My take: the need for backport is only that someone could be hitting this while working on support NumPy 2+ (which is still a real possibility, NumPy was ~2.5 years ago). To nudge against (for behavior fixes in general):
My point is: Any pins like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
np.searchsortednow castssorterwith same-kind casting, following #26610 (np.take) and #28355 (np.bincount). Integer arrays such asuint64, orint64on 32-bit platforms, now work.Same problem as #4384, for
np.searchsorted.AI Disclosure
An AI model was used to investigate the history of the issue and draft the changes.