TST: avoid allocating huge tuple of arrays in concatenate test - #32325
Merged
Merged
Conversation
ikrommyd
approved these changes
Aug 17, 2026
charris
approved these changes
Aug 17, 2026
Member
|
Thanks Nathan. |
charris
pushed a commit
that referenced
this pull request
Aug 18, 2026
charris
added a commit
that referenced
this pull request
Aug 18, 2026
TST: avoid allocating huge tuple of arrays in concatenate test (#32325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This test is causing flaky CI: https://github.com/numpy/numpy/actions/runs/31394421923/job/93475396840?pr=32239
Given that the test is mostly there to make sure the error path fires, I think it's OK to call
_implementationdirectly. As a bonus I can remove all the slow, thread-unsafe, and requires lots of RAM pytest markers.AI Disclosure
I used an AI to understand why this test was so slow on CI (it's causing the CI runners to swap).