Skip to content

DEP: expire deprecations in lib._shape_base_impl - #30463

Merged
charris merged 4 commits into
numpy:mainfrom
jorenham:expire-deprecated-lib._shape_base_impl
Dec 17, 2025
Merged

DEP: expire deprecations in lib._shape_base_impl#30463
charris merged 4 commits into
numpy:mainfrom
jorenham:expire-deprecated-lib._shape_base_impl

Conversation

@jorenham

@jorenham jorenham commented Dec 17, 2025

Copy link
Copy Markdown
Member

This removes row_stack and lib._shape_base_impl.get_array_wrap, both deprecated since 2.0.

towards #30440

@jorenham jorenham added this to the 2.5.0 Release milestone Dec 17, 2025
@jorenham jorenham mentioned this pull request Dec 17, 2025
Open
12 tasks
@jorenham

jorenham commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

I thought that get_array_wrap is private API only, so that's why I didn't include it in the release note. At least numpy.get_array_wrap raises an AttributeError on NumPy 2.3.

@charris

charris commented Dec 17, 2025

Copy link
Copy Markdown
Member

That is true, but it doesn't hurt to document the removal. Ideally, no one would use any of the deprecated functions.

@charris
charris merged commit abdb7bf into numpy:main Dec 17, 2025
77 checks passed
@charris

charris commented Dec 17, 2025

Copy link
Copy Markdown
Member

Thanks Joren.

@jorenham
jorenham deleted the expire-deprecated-lib._shape_base_impl branch December 18, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

07 - Deprecation component: numpy.lib

Projects

None yet

Milestone

2.5.0 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@jorenham @charris