Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66093 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 789 789
Lines 271623 271625 +2
Branches 51847 51853 +6
=======================================
+ Hits 245196 245211 +15
+ Misses 16910 16877 -33
- Partials 9517 9537 +20 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was splitting out threads to do separate server & client benchmarking. It turns out if you run QUIC in a worker thread and then terminate the worker (as in the test here) it hits an assert in QUIC that takes down the whole process.
This happens because the current code assumes that tidy JS closure will run first and trigger
Session::Destroy()before~Sessionwhich otherwise blows up. Terminating the worker skips this entirely. This PR is a small fix that sets up proper cleanup, so worker termination shuts down happily.